[FFmpeg-devel] first small patch for v3 VQA : format80 modification (GSOC Qualification task)

[Michael Niedermayer]

On Tue, Mar 31, 2009 at 11:37:32AM -0400, The Deep Explorer wrote:
> Hi ,
>     I modified the format80 to include the v3 changes.
> I am sure there are lots of mistakes , please be gentle.
> 
> I just wanted to share the patch as I go so that I can keep
> changing and improving.
> 
> I will be working on the vprz next.

trailing whitespace
modformat80.diff:20:+    
modformat80.diff:100:+	    
modformat80.diff:129:+	else    

tabs
modformat80.diff:23:+	}
modformat80.diff:46:+	    if(check_modification == 1){
modformat80.diff:49:+	      if(src_pos < 0){
modformat80.diff:50:+	         av_log(NULL, AV_LOG_ERROR, "  VQA video: decode_format80 problem: src_pos (%d) underflow\n",
modformat80.diff:53:+	      }
modformat80.diff:54:+	    }
modformat80.diff:55:+	    else{
modformat80.diff:58:+	    }
modformat80.diff:69:+	    if(check_modification == 1){
modformat80.diff:72:+	      if(src_pos < 0){
modformat80.diff:73:+	         av_log(NULL, AV_LOG_ERROR, "  VQA video: decode_format80 problem: src_pos (%d) underflow\n",
modformat80.diff:76:+	      }
modformat80.diff:77:+	    }
modformat80.diff:78:+	    else{
modformat80.diff:81:+	    }
modformat80.diff:99:+	/* this part for V3 */
modformat80.diff:100:+	    
modformat80.diff:104:+	     vprz_chunk = index;
modformat80.diff:127:+	if(vptz_chunk == -1)
modformat80.diff:129:+	else    

x==0 / x!=0 can be simplified to !x / x
modformat80.diff:21:+    if(vqa_header[14] == 0){

Missing context in av_log
modformat80.diff:50:+	         av_log(NULL, AV_LOG_ERROR, "  VQA video: decode_format80 problem: src_pos (%d) underflow\n",
modformat80.diff:73:+	         av_log(NULL, AV_LOG_ERROR, "  VQA video: decode_format80 problem: src_pos (%d) underflow\n",

missing } prior to else
modformat80.diff:24:+    else{
modformat80.diff:55:+	    else{
modformat80.diff:78:+	    else{
modformat80.diff:129:+	else    

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090331/b2ec74a4/attachment.pgp>