[FFmpeg-devel] [PATCH] Add missing pixdescs

Stefano Sabatini stefano.sabatini-lala
Tue Mar 31 21:04:27 CEST 2009


On date Tuesday 2009-03-31 05:30:48 +0200, Michael Niedermayer encoded:
> On Tue, Mar 31, 2009 at 02:49:51AM +0200, Stefano Sabatini wrote:
> > On date Monday 2009-03-30 01:12:51 +0200, Stefano Sabatini encoded:
> > > On date Sunday 2009-03-29 23:18:44 +0200, Michael Niedermayer encoded:
> > > > On Tue, Mar 24, 2009 at 09:51:26PM +0100, Stefano Sabatini wrote:
> > > > > Hi all,
> > > > > 
> > > > > cosmetics+reorder patch.
> > > > > 
> > > > > Second patch is unfortunately unreadable, what it does is to resort
> > > > > the pixdescs in the same order as the pixfmts, that should ease my
> > > > > future work of filling the gaps.
> > [...]
> > 
> > Summary:
> 
> > * pixdesc-fix-const.patch
> >   Fix write_line() constness.
> 
> ok

Applied.

[...] 
> > * pixdesc-readline-cosmetics.patch
> >   Various cosmetics.
> 
> rejected, i prefer the way it looks now

I won't insist on this, but I think is a good idea to keep a
consistent style throughout all the code, also spaces improve
readability.
 
> > * pixdesc-define-step-offset-for-bitstream.patch
> >   Change the semantics of the AVComponentDescriptor for bitstream
> >   formats.
> 
> this does just one thing, make the comment very ambigous

Sad but true.
 
> also please send 1 patch per mail

OK.

Regards.
-- 
FFmpeg = Foolish & Freak Minimalistic Problematic Efficient Gospel



More information about the ffmpeg-devel mailing list