[FFmpeg-devel] [PATCH] Move MLP's dot product to DSPContext

[Diego Biurrun]

On Fri, May 15, 2009 at 02:28:18PM -0300, Ramiro Polla wrote:
> On Fri, May 15, 2009 at 2:23 PM, Diego Biurrun <diego at biurrun.de> wrote:
> > On Fri, May 15, 2009 at 10:38:01AM -0300, Ramiro Polla wrote:
> >> #if ARCH_X86_64
> >>
> >> #else /* if ARCH_X86_32 */
> >>
> >> #endif /* ARCH_X86_32 */
> >
> > Hmmm...
> >
> > I find it confusing if the #endif comment differs from the #if condition.
> 
> And I find it confusing if the #endif comment relates to the first #if
> in a sequence.
> 
> Should it be:
> #if ARCH_X86_64
> #else /* ARCH_X86_32 */
> #endif /* ARCH_X86_64 */
> 
> or:
> #if ARCH_X86_64
> #else /* ARCH_X86_64 */
> #endif /* ARCH_X86_64 */
> 
> or just plain:
> #if ARCH_X86_64
> #else
> #endif /* ARCH_X86_64 */

I prefer the second.

Diego