[FFmpeg-devel] [PATCH] ALS decoder

[Thilo Borgmann]

Kurtnoise schrieb:
> Hi,
> 
> Thilo Borgmann a ?crit :
> 
>> Revision 24 attached.
>>
>> +    // read the fixed items
>> +    als_id                      = get_bits_long(&gb, 32);
>> +    avctx->sample_rate          = m4ac.sample_rate;
>> +    skip_bits_long(&gb, 32); // sample rate already known
>> +    sconf->samples              = get_bits_long(&gb, 32);
>> +    avctx->channels             = m4ac.channels;
>                                      ^^^^^^^^^^^^
> 
> Shouln't be m4ac.chan_config ?
> 

m4ac.chan_config is an index into an array of predefined configurations
(stereo, 5.1, etc.) that does not fit for ALS.
Therefore, m4ac.channels has been added in another patch that is
currently reviewed and represents the actual number of channels.
The channel configuration is still an open issue for ALS at the moment.

See "[PATCH] Parsing ALS object type in MPEG-4" for that patch.

-Thilo