[FFmpeg-devel] [PATCH] ALS decoder

Thilo Borgmann thilo.borgmann
Wed Nov 4 17:38:51 CET 2009


Michael Niedermayer schrieb:
> On Sat, Oct 31, 2009 at 12:58:59PM +0100, Thilo Borgmann wrote:
>> Revision 24 attached.
> 
> [...]
>> ...
>> +                quant_cof[0]  = parcor_scaled_values[get_bits(gb, 7)];
>> +                quant_cof[0] *= 32;
>> +
>> +                // read coefficient 1
>> +                quant_cof[1]  = -parcor_scaled_values[get_bits(gb, 7)];
>> +                quant_cof[0] *= 32;
> 
> is it intended to do this to [0] [0] / [1] [0] ?

No, corrected.

> 
> also isnt it possible for max_order to be one and thus the quant_cof array
> to be too small?

Indeed. If's added for both occurencies of quant_cof[1].

> 
> ...

Everything else done, too.

Thanks!

-Thilo



More information about the ffmpeg-devel mailing list