[FFmpeg-devel] [PATCH] do not set sample_fmt in lavf

[Michael Niedermayer]

On Sat, Nov 07, 2009 at 03:16:29PM -0500, Justin Ruggles wrote:
> Justin Ruggles wrote:
> 
> > Kostya wrote:
> > 
> >> On Sat, Oct 31, 2009 at 11:35:10PM -0400, Justin Ruggles wrote:
> >>> Justin Ruggles wrote:
> >>>
> >>>> Hi,
> >>>>
> >>>> The libavcodec documentation for AVCodecContext.sample_fmt says:
> >>>>      * - encoding: Set by user.
> >>>>      * - decoding: Set by libavcodec.
> >>>>
> >>>> There are 3 demuxers which are setting sample_fmt when they should not
> >>>> (and don't need to).  For Smacker Audio, the decoder should be setting
> >>>> it not the demuxer.
> >>>>
> >>>> Patch attached.
> >>>>
> >>>> -Justin
> >>> After a 2nd look, I think the Smacker decoder part was wrong.  New patch.
> >> Smacker decoder part is wrong - 8-bit samples are decoded as
> >> 8-bit in it.
> >> Simply moving that line from demuxer to decoder should be fine though.
> > 
> > Ok. I moved it and committed that part.
> > 
> > Here is a patch with just the other 2 changes.
> 
> ping.

fine if its tested & works

[..]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091107/9e73e091/attachment.pgp>