[FFmpeg-devel] [PATCH] fix sdp(file) vs rtsp dep

Luca Abeni lucabe72
Wed Nov 11 11:28:24 CET 2009


Luca Abeni wrote:
[...]
>> Anyway, the patch is quite big.  Maybe you could split it by first
>> moving the functions around.
> 
> Ok; I'll try to do this when I'll find some more time to work on this
> patch.

Next round of patches:
- move_functions-2.diff moves some code around, to simplify the following
   patches
- split_read-1.diff splits the sdp_read_packet() function out of
   rtsp_read_packet(). This allows to avoid compiling RTSP code when not
   needed (as done in the next patch).
- add-ifdefs.diff adds some ifdefs to avoid compiling the RTSP code when
   the RTSP demuxer is disabled, and removes a useless "#if CONFIG_SDP_DEMUXER"
The last patch should make it clear why I think that the RTSP demuxer
should depend on the SDP demuxer and not vice-versa...

I did not do any renaming yet, but I think it can be done later.
Some work is still needed to split the code in two different files
(sdp.c and rtsp.c) but I have no time right now...


				Luca
-------------- next part --------------
A non-text attachment was scrubbed...
Name: move_functions-2.diff
Type: text/x-diff
Size: 12129 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091111/fba45b8d/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: split_read-1.diff
Type: text/x-diff
Size: 4815 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091111/fba45b8d/attachment-0001.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: add-ifdefs.diff
Type: text/x-diff
Size: 1638 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091111/fba45b8d/attachment-0002.diff>



More information about the ffmpeg-devel mailing list