[FFmpeg-devel] [PATCH] split alldevices.c and prerequisites

[Michael Niedermayer]

On Fri, Nov 13, 2009 at 09:49:20PM +0100, Diego Biurrun wrote:
> On Thu, Nov 12, 2009 at 12:48:23AM +0100, Diego Biurrun wrote:
> > On Wed, Nov 11, 2009 at 11:44:37PM +0100, Michael Niedermayer wrote:
> > > On Wed, Nov 11, 2009 at 10:58:46PM +0100, Diego Biurrun wrote:
> > > > On Wed, Nov 11, 2009 at 10:33:34PM +0100, Michael Niedermayer wrote:
> > > > > On Wed, Nov 11, 2009 at 09:54:15PM +0100, Diego Biurrun wrote:
> > > > > > So I wanted to split alldevices.c into alldevices.c and avdevice.c.
> > > > > > It turns out that this is not so simple; here are the patches to do it.
> > > > > > 
> > > > > > avdevice.h is missing an avutil #include, same as avfilter.h and
> > > > > > avformat.h.  If I add the missing headers, the avformat.h #include makes
> > > > > > #undefs necessary in a lot of places.
> > > > > 
> > > > > alot of places should not define HAVE_AV_CONFIG_H
> > > > 
> > > > This is a sphinx-like statement.  What are you trying to say with regard
> > > > to my patch?
> > > 
> > > iam saying that alot of it shouldnt be needed
> > > what happens if you remove HAVE_AV_CONFIG_H from ff*.c
> > 
> > diego at slaughter:/var/tmp/diego/ffmpeg $ gcc -I.  -I"/var/tmp/diego/ffmpeg" -D_ISOC99_SOURCE -D_POSIX_C_SOURCE=200112 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -std=c99 -fomit-frame-pointer -g -Wdeclaration-after-statement -Wall -Wno-switch -Wdisabled-optimization -Wpointer-arith -Wredundant-decls -Wno-pointer-sign -Wcast-qual -Wwrite-strings -Wundef -O3 -fno-math-errno -fno-tree-vectorize         -MMD -MF ffserver.d -MT
> > ffserver.o -c -o ffserver.o ffserver.c
> > ffserver.c: In function `http_parse_request':
> > ffserver.c:1343: warning: implicit declaration of function `match_ext'
> > ffserver.c: In function `rtsp_cmd_describe':
> > ffserver.c:2781: warning: implicit declaration of function `url_split'
> > ffserver.c: In function `parse_ffconfig':
> > ffserver.c:3787: warning: implicit declaration of function `resolve_host'
> > 
> > Apparently ffserver.c uses some non-public functions from avformat.h.
> > The other two compile fine (after my last commit).
> 
> So what should be the solution?  Make these functions public or not use
> them in ffserver.c?

i guess match_ext and url_split could be made public with av prefix,
and documented API

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091114/617d4b03/attachment.pgp>