[FFmpeg-devel] [PATCH] Fix possible SIGFPEs with bad mov timings. Based on chromium patch 35_mov_bad_timings.patch

[Michael Niedermayer]

On Thu, Nov 19, 2009 at 12:12:30PM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Thu, Nov 19, 2009 at 1:45 AM, Baptiste Coudurier
> <baptiste.coudurier at gmail.com> wrote:
> > I don't like the < 0 check, but I guess we don't have much choice here.
> 
> Er...
> 
> A) AVURational (bikeshed!!!!111)

no i wont buy you a second bike because you dont like the color of the one
you alraedy have


> B) uint32_t num = READ_BE32(..), den = READ_BE32(..);
>     if (num & 0x80000000 || den & 0x80000000) { den >>= 1; num >>= 1 }

dont do this period
we have av_reduce() that does this properly, and av_set_pts_info() already
uses it.


> 
> It's not like this 32th bit is suddenly gonna cause a movie to go out of sync...

no, ill bet it is already out of sync ;)
besides the loss of precission by av_reduce() should be quite small


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091119/e23c6375/attachment.pgp>