[FFmpeg-devel] [PATCH] Fix possible SIGFPEs with bad mov timings. Based on chromium patch 35_mov_bad_timings.patch

Ronald S. Bultje rsbultje
Thu Nov 19 20:52:43 CET 2009


Hi,

On Thu, Nov 19, 2009 at 2:37 PM, Albert J. Wong (???)
<ajwong at chromium.org> wrote:
> How about something like
>
> if (c->time_scale < 0)
> ?return AVERROR_INVALIDDATA;
> else if (!c->time_scale)
> ?c->time_scale = 1;
> if (sc->time_scale <=0) {
> ? // the log message whatever that was...
> ?sc_time_scape = c->time_scale;
> }
>
> ?
>
> That lets us handle the raw case, and chooses to ignore the potentially
> negative values. ?Is there's a better middle ground that I'm missing?

Putting this in any (=> every) demuxer is silly, imo.

Ronald



More information about the ffmpeg-devel mailing list