[FFmpeg-devel] [PATCH] encoder for adobe's flash ScreenVideo2 codec

[Daniel Verkamp]

On Fri, Nov 20, 2009 at 1:46 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Fri, Nov 20, 2009 at 01:31:43PM -0600, Daniel Verkamp wrote:
>> On Fri, Nov 20, 2009 at 12:34 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> > On Fri, Nov 20, 2009 at 04:14:28PM +0100, Benjamin Larsson wrote:
>> > [...]
>> > ok
>> >
>> > [...]
>>
>> Approved hunks applied.
>>
>> This hunk from the encoder patch seems straightforward enough also and
>> allows -vcodec copy to work (only with the decoder added, though; is
>> it intentional/known that -vcodec copy does not work when no decoder
>> for that codec id is registered?);
>
> hmm, what is the problem if no decoder is available?
> i thought this worked in the past but i might be wrong
>

Given a command line like:

ffmpeg -i /files/media-samples/flash-screen/screen2.flv -vcodec copy
~/temp/screen2-copy.flv

It falls over with:

[flv @ 0x25813c0]Could not find codec parameters (Video: 0x0000, 200 kb/s)
/files/media-samples/flash-screen/screen2.flv: could not find codec parameters

>
>> ok to apply?
>>
>> Index: libavformat/flvenc.c
>> ===================================================================
>> --- libavformat/flvenc.c ? ? ?(revision 19479)
>> +++ libavformat/flvenc.c ? ? ?(working copy)
>> @@ -29,6 +29,7 @@
>> ?static const AVCodecTag flv_video_codec_ids[] = {
>> ? ? ?{CODEC_ID_FLV1, ? ?FLV_CODECID_H263 ?},
>> ? ? ?{CODEC_ID_FLASHSV, FLV_CODECID_SCREEN},
>> + ? ?{CODEC_ID_FLASHSV2, FLV_CODECID_SCREEN2},
>> ? ? ?{CODEC_ID_VP6F, ? ?FLV_CODECID_VP6 ? },
>> ? ? ?{CODEC_ID_VP6, ? ? FLV_CODECID_VP6 ? },
>> ? ? ?{CODEC_ID_H264, ? ?FLV_CODECID_H264 ?},
>
> ok
>

Applied.

Thanks,
-- Daniel Verkamp