[FFmpeg-devel] [PATCH] encoder for adobe's flash ScreenVideo2 codec

[Daniel Verkamp]

On Fri, Nov 20, 2009 at 3:11 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Fri, Nov 20, 2009 at 03:07:11PM -0600, Daniel Verkamp wrote:
>> On Fri, Nov 20, 2009 at 3:00 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> [...]
>> >> >
>> >> > hmm, what is the problem if no decoder is available?
>> >> > i thought this worked in the past but i might be wrong
>> >> >
>> >>
>> [...]
>> > and if you simply outcomment the exit call in ffmpeg.c ?
>> >
>>
>> Then it does indeed work (removing the av_exit() call after "could not
>> find codec parameters" message), but presumably it is there for some
>> reason.
>
> hmm, maybe the reason is so it is removed?
> anyway, if you jst remove it the reply ?to your commit will between
> various personal insults tell us what it was good for ;)
> i think this would be the most effective way especially as neither
> of us seems to know what that exit could be good for

I take that back; I tested the ffmpeg.c change on the wrong branch
(the one with the decoder patch applied). :)

With just the codec id and muxer+demuxer patches, no decoder, it does not work:

[flv @ 0x2307b60]dimensions not set
Output #0, flv, to '/home/daniel/temp/screen2-copy.flv':
    Stream #0.0: Video: 0x0000, q=2-31, 200 kb/s, 90k tbn, 1k tbc
Stream mapping:
  Stream #0.0 -> #0.0
Could not write header for output file #0 (incorrect codec parameters ?)

Reading the demuxer now, flv doesn't set width/height itself and
depends on the codec to set them, hence the codec parameters test
fails (rightfully).  I guess there is no bug here after all.

Thanks,
-- Daniel Verkamp