[FFmpeg-devel] [PATCH] Update lix264.c for x264 API change (X264_BUILD 79)

[Jason Garrett-Glaser]

On Sat, Nov 21, 2009 at 2:21 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Sat, Nov 21, 2009 at 11:28:57AM -0800, Jason Garrett-Glaser wrote:
>> OK, updated patch attached.
> [...
>> Index: libavcodec/avcodec.h
>> ===================================================================
>> --- libavcodec/avcodec.h ? ? ?(revision 20562)
>> +++ libavcodec/avcodec.h ? ? ?(working copy)
>> @@ -2553,6 +2553,13 @@
>> ? ? ? * - decoding: Set by libavcodec, user can override.
>> ? ? ? */
>> ? ? ?int (*execute2)(struct AVCodecContext *c, int (*func)(struct AVCodecContext *c2, void *arg, int jobnr, int threadnr), void *arg2, int *ret, int count);
>> +
>> + ? ?/**
>> + ? ? * explicit weighted prediction analysis method
>> + ? ? * - encoding: Set by user.
>> + ? ? * - decoding: unused
>> + ? ? */
>> + ? ?int weighted_p_pred;
>> ?} AVCodecContext;
>
> This documentation is insufficient to use this field.
> It tells the reader what the field does but not which value does
> what

How should we keep the documentation in ffmpeg synced with the values
in x264 then?  We may add new values in the future.

Dark Shikari