[FFmpeg-devel] [PATCH] Remove not truly supported formats support from the crop filter

[Michael Niedermayer]

On Sat, Nov 21, 2009 at 01:12:00PM +0100, Stefano Sabatini wrote:
> Hi all,
> 
> the crop filter algorithm doesn't work with all the listed formats, or
> it works with them only under certain conditions.
> 
> In particular the algorithm works only with formats:
> 
> * which have all the components on the same plane and with the same
>   chroma shift
> 
> * which have just one component per plane
> 
> The following formats:
>         PIX_FMT_NV12,         PIX_FMT_NV21,
>         PIX_FMT_YUYV422,      PIX_FMT_UYVY422,
>         PIX_FMT_UYYVYY411,
> 
> don't have any of the abovementioned properties, so the crop filter
> doesn't work correctly with these formats.
> 
> My suggestion is to apply this patch, then when pixdescs will be
> usable shouldn't be too hard to extend the crop filter to support
> these formats.
> 
> Regards.
> -- 
> FFmpeg = Freak and Fast Majestic Problematic Enigmatic Governor

>  vf_crop.c |    3 ---
>  1 file changed, 3 deletions(-)
> cb0247c66d7003b2bd62561429f07e8b0eb3aeb6  fix-crop-filter.patch

ok if you confirmed that they actually fail

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091122/4bfad132/attachment.pgp>