[FFmpeg-devel] [PATCH] als in mov

[Baptiste Coudurier]

On 11/21/09 7:19 PM, Justin Ruggles wrote:
> Hi,
>
> This patch fixes muxing of MPEG-4 ALS in MOV.
>

Can this be verified with any other decoder than lavc ?
Does reference decoder works ?

Besides an object type to put in esds is needed, and which fourcc is used ?

> [...]
>
> Index: libavformat/movenc.c
> ===================================================================
> --- libavformat/movenc.c	(revision 20571)
> +++ libavformat/movenc.c	(working copy)
> @@ -371,7 +371,8 @@
>       put_tag(pb, "frma");
>       put_le32(pb, track->tag);
>
> -    if (track->enc->codec_id == CODEC_ID_AAC) {
> +    if (track->enc->codec_id == CODEC_ID_AAC ||
> +        track->enc->codec_id == CODEC_ID_MP4ALS) {
>           /* useless atom needed by mplayer, ipod, not needed by quicktime */
>           put_be32(pb, 12); /* size */
>           put_tag(pb, "mp4a");
> @@ -452,7 +453,8 @@
>           track->enc->codec_id == CODEC_ID_AMR_NB ||
>           track->enc->codec_id == CODEC_ID_PCM_S24LE ||
>           track->enc->codec_id == CODEC_ID_PCM_S32LE ||
> -        track->enc->codec_id == CODEC_ID_ALAC))
> +        track->enc->codec_id == CODEC_ID_ALAC ||
> +        track->enc->codec_id == CODEC_ID_MP4ALS))

Avoid one line of diff by putting it before :)

[...]

-- 
Baptiste COUDURIER
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org