[FFmpeg-devel] [PATCH] Implement a cmdutils functions for listing available elements

Stefano Sabatini stefano.sabatini-lala
Sun Nov 22 18:41:04 CET 2009


On date Friday 2009-11-20 19:18:28 +0100, Michael Niedermayer encoded:
> On Fri, Nov 20, 2009 at 12:06:04AM +0100, Stefano Sabatini wrote:
> > On date Thursday 2009-11-19 17:38:14 +0100, Michael Niedermayer encoded:
> > > On Wed, Nov 18, 2009 at 11:59:17PM +0100, Stefano Sabatini wrote:
> > [...]
> > > no, your patch does something quite different.
> > > anyway, ive implemented it myself, this took less time than reviewing your
> > > patches
> > 
> > I still continue to prefer the -list elts approach, but then I don't
> > care so much and your approach looks still acceptable.
> 
> just for the record:
> you could have changed the existing code to "-list elts approach"
> with a patch very similar to mine which would have been much clearer
> and i would proably have accepted it. (now its of course no longer
> needed)

Maybe we're still in time to change it, as I stated opt_list() is more
compact and can be extended without to add other options (we still
have enough of them).

Also it avoids the show_protocol() mess and ripristinate the -formats
behavior (this is IMO a good feature, as that option is there by ages
so it's better to remove it than to change its behavior).

Yes this patch breaks again the interface, but since those options are
new then it should do little harm.

I'll provide a patch fixing docs as well if this approach is
acceptable.

Regards.
-- 
FFmpeg = Faithful and Fostering Mega Portable Elastic Guru
-------------- next part --------------
A non-text attachment was scrubbed...
Name: opt-list-again.patch
Type: text/x-diff
Size: 5724 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091122/e3e8b425/attachment.patch>



More information about the ffmpeg-devel mailing list