[FFmpeg-devel] [RFC] Request for pixdesc API review

[Michael Niedermayer]

On Mon, Nov 23, 2009 at 09:48:49PM +0100, Stefano Sabatini wrote:
> On date Monday 2009-11-09 12:05:15 -0500, Ronald S. Bultje encoded:
> [...]
> > What is the BITSTREAM flag? Is it the same as "no padding to align
> > each pixel to the byte"? Some explanation there would help me, I'd
> > have to look at the code to see what it does.
> 
> Is the attached patch somehow clarifying?
> 
> Regards.
> -- 
> FFmpeg = Friendly and Fierce MultiPurpose Exploitable Game

>  pixdesc.h |    6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 52983fe25db2467e1fa075ebff291e9e258dc7bb  clarify-pix-desc-bistream.patch
> Index: ffmpeg/libavutil/pixdesc.h
> ===================================================================
> --- ffmpeg.orig/libavutil/pixdesc.h	2009-11-23 21:05:53.000000000 +0100
> +++ ffmpeg/libavutil/pixdesc.h	2009-11-23 21:21:39.000000000 +0100
> @@ -86,7 +86,11 @@
>  
>  #define PIX_FMT_BE        1 ///< Pixel format is big-endian.
>  #define PIX_FMT_PAL       2 ///< Pixel format has a palette in data[1], values are indexes in this palette.
> -#define PIX_FMT_BITSTREAM 4 ///< All values of a component are bit-wise packed end to end.
> +/**
> + * All values of a component are bit-wise packed end to end, that is,
> + * the bits of the component values are not byte-aligned.

i for one dont consider this better

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091123/e36370b2/attachment.pgp>