[FFmpeg-devel] [PATCH] Use pixdesc for avcodec_get_pix_fmt_name()

Stefano Sabatini stefano.sabatini-lala
Thu Nov 26 22:03:11 CET 2009


On date Thursday 2009-11-26 21:40:36 +0100, Michael Niedermayer encoded:
> On Thu, Nov 26, 2009 at 09:13:37PM +0100, Stefano Sabatini wrote:
[...]
> > > If we want to make a compatibility breaking change (and at least i do NOT
> > > want this because it has no point at all). Then the table entries can be
> > > changed when this compatibility breaking change is done.
> > 
> > I'm OK with this, but I continue to prefer names which are consistent
> > with the enum name, that's true for all the other pixel format, I
> > don't want to keep that arbitrary asymetry.
> 
> thats a seperate thing and does not belong in a patch switching between
> 2 structs, and even less just half of that change with a hack to undo
> it again
> 
> 
> > 
> > Please check again if you like this approach.
> > 
> > Regards.
> > -- 
> > FFmpeg = Fast & Frightening Mortal Powered Enlightening Genius
> 
> >  pixdesc.c |   10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> > cfc776b967774ef9dfe6c2a08222b4d97736eca7  use-weird-names-in-pixdescs.patch
> 
> ok
> [..]
> >  imgconvert.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 445a49f39094ac934ba43b7d6f810a70fe32dbbb  use-av-pix-desc-for-pixname.patch
> 
> ok

Both applied.
-- 
FFmpeg = Frenzy and Foolish Maxi Power Easy Gadget



More information about the ffmpeg-devel mailing list