[FFmpeg-devel] [PATCH]Fix one icc warning

Måns Rullgård mans
Fri Oct 2 17:41:27 CEST 2009


Carl Eugen Hoyos <cehoyos at rainbow.studorg.tuwien.ac.at> writes:

> Hi!
>
> Attached patch fixes this icc warning:
> warning #1011: missing return statement at end of non-void function
> "avformat_seek_file"
>
> Please comment, Carl Eugen
>
> Index: libavformat/utils.c
> ===================================================================
> --- libavformat/utils.c	(revision 20108)
> +++ libavformat/utils.c	(working copy)
> @@ -1594,7 +1594,7 @@
>  
>      //Fallback to old API if new is not implemented but old is
>      //Note the old has somewat different sematics
> -    if(s->iformat->read_seek || 1)
> +    if(1 || s->iformat->read_seek)
>          return av_seek_frame(s, stream_index, ts, flags | (ts - min_ts > (uint64_t)(max_ts - ts) ? AVSEEK_FLAG_BACKWARD : 0));

WTF is this?  What's the purpose of the obfuscation, and why does it
matter to the compiler?

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list