[FFmpeg-devel] [PATCH] Implement recusive avfilter_get_video_buffer()

[Michael Niedermayer]

On Thu, Oct 08, 2009 at 12:57:08AM +0200, Stefano Sabatini wrote:
> On date Thursday 2009-10-08 00:05:24 +0200, Michael Niedermayer encoded:
> > On Wed, Oct 07, 2009 at 09:24:45PM +0200, Stefano Sabatini wrote:
> [...]
> > > For what regards the soc patch, is OK to apply that as well once this
> > > is applied?
> > 
> > 
> > [...]
> > >  avfilter.c |   13 ++++++++-----
> > >  avfilter.h |   15 +++++++++------
> > >  defaults.c |    8 ++++----
> > >  3 files changed, 21 insertions(+), 15 deletions(-)
> > > ad7c75f534241787cf08f3b8ba6f735ae2168ebe  lavfi-recursive-get-video-buffer.patch
> > 
> > Probably ok but this should be tested better too much than too little
> > if you have any regression tests please check that they dont change due to
> > this ...
> 
> I'm currently testing in the soc repo using the attached regression
> tests (the file must be places in diffs). If that's OK for you I'll
> add that to the soc repo.

[...]

> Index: tests/codec-regression.sh
> ===================================================================
> --- tests/codec-regression.sh	(revision 20189)
> +++ tests/codec-regression.sh	(working copy)
> @@ -677,10 +677,15 @@
>      fi
>  }
>  
> -# example tests:
> -# do_lavfi "crop" "crop=100:100:-1:-1"
> -# do_lavfi "crop_scale" "crop=100:100,scale=200:-1"
> -# do_lavfi "scale" "scale=200:200"
> +do_lavfi "null" "null"
> +do_lavfi "crop" "crop=100:100:-1:-1"
> +do_lavfi "crop_scale" "crop=100:100,scale=200:-1"
> +do_lavfi "crop_vflip" "crop=100:100,vflip"
> +do_lavfi "scale200" "scale=200:200"
> +do_lavfi "scale500" "scale=500:500"
> +do_lavfi "vflip" "vflip"
> +do_lavfi "vflip_crop" "vflip,crop=100:100"
> +do_lavfi "vflip_vflip" "vflip,vflip"

try that: (with parameters that let each filter do something more than null)

null,null,crop,crop,scale,scale,vflip,vflip,null,scale,crop,vflip,scale,null,vflip,crop,null

also make sure that slices and frame reordering are in use from the input.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091008/a2346b4c/attachment.pgp>