[FFmpeg-devel] [PATCH] Parsing ALS object type in MPEG-4

[Baptiste Coudurier]

On 10/9/09 1:48 PM, Alex Converse wrote:
> On Sun, Aug 23, 2009 at 3:51 PM, Thilo Borgmann
> <thilo.borgmann at googlemail.com>  wrote:
>> Index: libavcodec/mpeg4audio.h
>> ===================================================================
>> --- libavcodec/mpeg4audio.h     (revision 19689)
>> +++ libavcodec/mpeg4audio.h     (working copy)
>> @@ -36,6 +36,7 @@
>>      int ext_sampling_index;
>>      int ext_sample_rate;
>>      int ext_chan_config;
>> +    int channels;
>>   } MPEG4AudioConfig;
>
> Can we put "channels" directly below "chan_config" without API/ABI
> breakage? If so I'd like to try to keep related thing together.

We could since this struct is not part of the public API, though since 
libavformat uses libavcodec, it is not safe.

This reminds me, I think avcodec_register_all and av_register_all should 
put requirements for libavcodec and libavutil versions respectively, to 
avoid shared libraries problems, because soname only contains major 
version and API changes only update minor version.

-- 
Baptiste COUDURIER
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org