[FFmpeg-devel] [PATCH] hardcoded ff_cos tables

Reimar Döffinger Reimar.Doeffinger
Tue Oct 13 14:41:33 CEST 2009


On Tue, Oct 13, 2009 at 01:29:39PM +0100, M?ns Rullg?rd wrote:
> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
> 
> > Hello,
> > attached patch allows hardcoding the ff_cos tables so they are in
> > .rodata instead of .bss.
> > Not included is the cos_tables.h file as generated by costablegen.c
> > since it is > 1.7 MB.
> > Which I admit is a bit of an issue, including this file directly into
> > SVN is not all that great, but it would be the simplest solution by far...
> 
> We could generate the tables at build time.

Not with this patch, since that reuses the libavcodec/fft.c code to
generate them, which will be disabled with hardcoded tables enabled.
It is of course possible to just duplicate the code from
libavcodec/fft.c, but that is not that beautiful either...



More information about the ffmpeg-devel mailing list