[FFmpeg-devel] [PATCH] hardcoded ff_cos tables

Diego Biurrun diego
Wed Oct 14 10:12:54 CEST 2009


On Wed, Oct 14, 2009 at 09:53:10AM +0200, Reimar D?ffinger wrote:
> --- libavcodec/Makefile	(revision 20231)
> +++ libavcodec/Makefile	(working copy)
> @@ -574,3 +574,5 @@
>  
>  $(SUBDIR)dct-test$(EXESUF): $(SUBDIR)dctref.o
> +cos_tables.h: costablegen
> +	./costablegen > cos_tables.h

Leave an empty line before the rule and use automatic variables:

        ./$< > $@

> --- libavcodec/costablegen.c	(revision 0)
> +++ libavcodec/costablegen.c	(revision 0)
> @@ -0,0 +1,46 @@
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with FFmpeg; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> + */

An empty line here ..

> +#include <stdio.h>
> +#include "libavutil/mathematics.h"
> +#undef fprintf
> +#define BITS 16
> +#define FLOATFMT "%.18e"

.. and here would aid readability IMO.

Diego



More information about the ffmpeg-devel mailing list