[FFmpeg-devel] [PATCH] hardcoded ff_cos tables

[Måns Rullgård]

Diego Biurrun <diego at biurrun.de> writes:

> On Wed, Oct 14, 2009 at 01:35:10PM +0200, Reimar D?ffinger wrote:
>> 
>> --- libavcodec/Makefile	(revision 20231)
>> +++ libavcodec/Makefile	(working copy)
>> @@ -28,6 +28,7 @@
>>  OBJS-$(CONFIG_AANDCT)                  += aandcttab.o
>>  OBJS-$(CONFIG_ENCODERS)                += faandct.o jfdctfst.o jfdctint.o
>>  OBJS-$(CONFIG_FFT)                     += fft.o
>> +HARDCODED-TABLES-OBJS-$(CONFIG_FFT)    += cos_tables.o
>
> FFT-OBJS-$(CONFIG_HARDCODED_TABLES)    += cos_tables.o
> OBJS-$(CONFIG_FFT)                     += fft.o $(FFT-OBJS-yes)
>
> That should make some of your other changes unnecessary.
>
>> --- libavcodec/cos_tables.h	(revision 0)
>> +++ libavcodec/cos_tables.h	(revision 0)
>> @@ -0,0 +1,17 @@
>> +#ifndef AVCODEC_COS_TABLES_H
>> +#define AVCODEC_COS_TABLES_H
>
> Please the standard license header (and maybe a few empty lines).

It's a list of numbers, hardly subject to copyright.  You're being a
bit too pedantic.

>> +#endif
>
> Please add an #endif comment.

I still think this should be a C file.

-- 
M?ns Rullg?rd
mans at mansr.com