[FFmpeg-devel] [PATCH] hardcoded ff_cos tables

Reimar Döffinger Reimar.Doeffinger
Wed Oct 14 19:15:58 CEST 2009


On Wed, Oct 14, 2009 at 05:36:07PM +0100, M?ns Rullg?rd wrote:
> > Because they need to be const for the hardcoded case and not const
> > for the other one (well, actually they are not needed at all in that
> > case).
> 
> Whatever you're putting in this file you could put in an existing
> file.

Yes, but it needs an extra #if.

> As for the need, everything with external linkage should be
> declared in some header IMHO.  Furthermore, someone might want to use
> those tables from C code too, not just asm.

Which is a completely unrelated, already existing mess.
And no, I can't see a reason to use those tables from C code, that's
what ff_cos_tab is there for (and it _might_ even make sense to use it
from asm code).



More information about the ffmpeg-devel mailing list