[FFmpeg-devel] [PATCH] remove duplicate initialization of ff_cos_tabs in rdft.c

Måns Rullgård mans
Thu Oct 15 12:39:37 CEST 2009

Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:

> Hello,
> ff_rdft_init initializes the ff_cos_tabs already initialized by
> ff_fft_init (which it already calls).
> Even worse, it will initialize it with possibly slightly different
> values (fft.c uses tab[m/2-i] = tab[i]; which IMO is a rather good idea,
> and would be an even better on for sin, since sin() is far more precise
> close to 0).
> This also means it will crash when compiled with hardcoded tables (what
> things use rdft.c? Nothing that is used by make test it seems?).

QDM2 seems to use it.

M?ns Rullg?rd
mans at mansr.com

More information about the ffmpeg-devel mailing list