[FFmpeg-devel] [PATCH]Do not free non-allocated memory

Baptiste Coudurier baptiste.coudurier
Fri Oct 16 19:30:27 CEST 2009

On 10/16/2009 8:40 AM, Reimar D?ffinger wrote:
> On Fri, Oct 16, 2009 at 06:14:11PM +0300, Kostya wrote:
>> On Fri, Oct 16, 2009 at 05:00:53PM +0200, Carl Eugen Hoyos wrote:
>>> Hi!
>>> As spotted by Alex Converse in a patch I sent recently. I believe his
>>> comment is also true for these files.
>>> Please comment, Carl Eugen
>> Indeed, seems so.
>> Please apply.
> Maybe someone could be convinced to write a test program that just calls
> init() and close() or whatever it is called on all "things" (codecs,
> muxers,...) that would allow to easily spot such things with valgrind?

I think all this get_buffer code should be factored out in decode_video.
if possible, depending on CODEC_CAP_DR1, also we should introduce 
CODEC_CAP_REGET when the decoder uses reget_buffer.

I would simplify decoders and code I think.

Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org

More information about the ffmpeg-devel mailing list