[FFmpeg-devel] [PATCH]Lagarith decoder.

[Nathan Caldwell]

On Fri, Oct 16, 2009 at 6:46 AM, Loren Merritt <lorenm at u.washington.edu> wrote:
> On Thu, 15 Oct 2009, Nathan Caldwell wrote:
>>
>> On Tue, Oct 13, 2009 at 3:28 AM, Michael Niedermayer <michaelni at gmx.at>
>> wrote:
>>>
>>>> +/* compute the 52bit mantissa of 1/(double)denom */
>>>> +static uint64_t softfloat_reciprocal(uint32_t denom)
>>>
>>> comment not doxygen compatible
>>> and this really needs some explanation of why it is used instead of
>>> 1.0/denom in the doxy
>>
>> Updated. It would be nice if Loren could comment on these descriptions.
>>
>> + This is used because it is more portable across architectures and
>> + toolchains than using floats.
>
> I wouldn't say that explains anything. How about:
>
> This crazy format uses floats in an entropy coder, thus we have to match
> x86's rounding exactly, thus ordinary floats aren't portable enough.

Haha, I like it.
Updated locally.

-- 
-Nathan Caldwell