[FFmpeg-devel] [PATCH] Implement avfilter_make_format_list2(enum PixelFormat pix_fmt, ...)

Michael Niedermayer michaelni
Sun Oct 18 23:04:09 CEST 2009


On Sun, Oct 18, 2009 at 09:32:37AM +0200, Stefano Sabatini wrote:
> On date Sunday 2009-10-18 01:13:34 +0200, Michael Niedermayer encoded:
> > On Sun, Oct 18, 2009 at 12:00:59AM +0200, Stefano Sabatini wrote:
> [...]
> > > Index: ffmpeg-vfilters/ffmpeg/libavfilter/formats.c
> > > ===================================================================
> > > --- ffmpeg-vfilters.orig/ffmpeg/libavfilter/formats.c	2009-10-17 23:46:40.000000000 +0200
> > > +++ ffmpeg-vfilters/ffmpeg/libavfilter/formats.c	2009-10-17 23:47:13.000000000 +0200
> > > @@ -87,6 +87,23 @@
> > >      return ret;
> > >  }
> > >  
> > > +AVFilterFormats *avfilter_make_format_list2(enum PixelFormat *pix_fmt)
> > > +{
> > > +    AVFilterFormats *formats;
> > > +    int count;
> > 
> > > +    enum PixelFormat *p;
> > > +
> > > +    for (count = 0, p = pix_fmt; *p != PIX_FMT_NONE; p++, count++)
> > > +        ;
> > 
> > too many ; and , on one line (unreadable)
> > i suggest:
> > 
> > for(i=0; pix_fmt[i]; i++)
> >     ;
> 
> Yes. BTW, what should we do with the old function, I mean should we
> deprecate it?

remove it once it is unused, then rename list2 to list


> 
> Regards.
> -- 
> FFmpeg = Frightening & Fast Mastodontic Picky Ecstatic God

>  avfilter.h |    8 ++++++++
>  formats.c  |   16 ++++++++++++++++
>  2 files changed, 24 insertions(+)
> 1ae1ed4910a4b9fdc9c4426d77f8c123689ba45c  implement-make-format-list2.patch

ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091018/75f569fa/attachment.pgp>



More information about the ffmpeg-devel mailing list