[FFmpeg-devel] [PATCH] fix sdp(file) vs rtsp dep

[Luca Abeni]

Luca Abeni wrote:
[...]
>> Right now the code and the dependency declaration in the build system
>> are contradictory.  That's why it fails to build in some configurations.
> 
> I do not disagree with this. I was just trying to point out that this
> part of the patch is unneeded and (IMHO) wrong.
> 
>> Decide which of the two possibilities is the better one and fix the
>> issue in one direction or the other.
> 
> I had no time to test it, but I suspect Luca's patch without the
> previous hunk works just fine. I'll do some tests tomorrow.

I finally found some time to run some tests, and it seems to me that the 
situation is much simpler than expected: I might be wrong, but I think 
the SDP demuxer is just missing a dependency on rdt.o in 
libavformat/Makefile.

So, I believe the attached patch should do the correct thing. I think 
what happened is that when rdt.c was added the Makefile was not properly 
updated.


That said, I am not sure if having a
	rtsp_demuxer_deps="sdp_demuxer"
in configure and repeating
	OBJS-$(CONFIG_RTSP_DEMUXER)              += rtsp.o        \
         	                                    rdt.o         \
                 	                            rtp_asf.o     \
                         	                    rtp_vorbis.o
in libavformat/Makefile is the best thing to do (it looks redundant): 
since we say that the rtsp demuxer depends on the sdp demuxer, is it 
necessary to repeat all the object files already required by the sdp 
demuxer?
If yes, then I think rtp.o and rtp_h264.o are missing (basically, if the 
answer to the previous question is "yes", then the 
"OBJS-$(CONFIG_RTSP_DEMUXER)" and "OBJS-$(CONFIG_SDP_DEMUXER)" should 
have the same dependencies). If no, then a simple
	OBJS-$(CONFIG_RTSP_DEMUXER)              += rtsp.o
is enough (or maybe we can just avoid the "OBJS-$(CONFIG_RTSP_DEMUXER)" 
line?).

			Thanks,
				Luca
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-rtsp-build.diff
Type: text/x-diff
Size: 622 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091019/b9bb8bac/attachment.diff>