[FFmpeg-devel] [PATCH] Ogg/Speex muxer

Michael Niedermayer michaelni
Tue Oct 20 10:48:21 CEST 2009


On Sun, Feb 15, 2009 at 12:20:36AM +1100, Peter Ross wrote:
> On Fri, Feb 06, 2009 at 12:03:41PM -0800, Baptiste Coudurier wrote:
> > Hi Peter,
> > 
> > On 2/6/2009 8:00 AM, Peter Ross wrote:
> > > $subject.
> > > 
> 
> > Can the vorbis/speex comment code be applied separately and used with
> > vorbis ? If so please do that so vorbis can benefit of metadata too.
> 
> It has been designed with vorbis integration in mind. Alas I am not going
> to tackle this immediately, as it requires reworking of the
> ff_xiph_split_headers() function.
> 
> > Should we rebuild extradata when speex is in flv and therefore contains
> > none ?
> 
> Yep. Done.
> 
> Files muxed using this patch have been tested with the reference
> speex decoder and various players. There are outstanding problems
> conterning use of the speex 'terminator' bit, that cause stuttered
> playback with some players. Each container format seems to use this
> bit differently, i.e. inserting the bit after each frame, group of
> frames, end of stream or not at all.
> 
> Ideally a parser is needed to remove/insert this bit.

Whats the status of this patch?
it hasnt been applied, rejected nor fully reveiwed
(iam trying to reduce the number of patches iam trying to keep track of)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091020/3b73b332/attachment.pgp>



More information about the ffmpeg-devel mailing list