[FFmpeg-devel] [PATCH] Ogg/Speex muxer

[Justin Ruggles]

Michael Niedermayer wrote:

> On Sun, Feb 15, 2009 at 12:20:36AM +1100, Peter Ross wrote:
>> On Fri, Feb 06, 2009 at 12:03:41PM -0800, Baptiste Coudurier wrote:
>>> Hi Peter,
>>>
>>> On 2/6/2009 8:00 AM, Peter Ross wrote:
>>>> $subject.
>>>>
>>> Can the vorbis/speex comment code be applied separately and used with
>>> vorbis ? If so please do that so vorbis can benefit of metadata too.
>> It has been designed with vorbis integration in mind. Alas I am not going
>> to tackle this immediately, as it requires reworking of the
>> ff_xiph_split_headers() function.
>>
>>> Should we rebuild extradata when speex is in flv and therefore contains
>>> none ?
>> Yep. Done.
>>
>> Files muxed using this patch have been tested with the reference
>> speex decoder and various players. There are outstanding problems
>> conterning use of the speex 'terminator' bit, that cause stuttered
>> playback with some players. Each container format seems to use this
>> bit differently, i.e. inserting the bit after each frame, group of
>> frames, end of stream or not at all.
>>
>> Ideally a parser is needed to remove/insert this bit.
> 
> Whats the status of this patch?
> it hasnt been applied, rejected nor fully reveiwed
> (iam trying to reduce the number of patches iam trying to keep track of)

A different patch has been applied for the basic Speex muxing.  The
VorbisComment writing has not and would be very welcome if done so that
it could be shared between the Ogg muxer (for all relevant codecs) and
the FLAC muxer.

-Justin