[FFmpeg-devel] [PATCH] seek print NOPTS

[Baptiste Coudurier]

On 10/20/2009 11:24 AM, Reimar D?ffinger wrote:
> Are you sure you read that thread really? Because I feel I must have read
> something else...

Of course you read something else, no wonder why :)

> On Tue, Oct 20, 2009 at 11:17:53AM -0700, Baptiste Coudurier wrote:
>> Quoting Reimar:
>> "Uh.. could you please explain the sense behind that? Because like this,
>> you complicate the code _and_ it is just wrong..."
>
> You are quoting me out of context. That was the response to just printing
> -1. While personally I think that the previous handling of AV_NOPTS_VALUE
> was wrong/a bad idea, too, -1 can reasonably appear in the output and thus
> printing -1 for AV_NOPTS_VALUE is just wrong IMO.

I think it is completely _in_ the context, and a suggestion to print 
"NOPTS" instead of -1 could have been definitely mentioned in the first 
place instead, instead of "Uh ... you complicate the code... and it is 
just wrong", because, well IMHO the idea behind is _right_, and you took 
it in your patch.

>> Now changing to NOPTS is ok for cosmetics reason ? And you guys
>> couldn't suggest that in the first place ?
>
> Michael did suggest something like I ended up doing in one

The problem is that fixing windows regression tests is IMHO far more 
important than this cosmetic change, however in the past thread, IMHO it 
seems that instead of working together in the best direction for the 
code itself, people ended up rejecting it in a unreasonable manner.

-- 
Baptiste COUDURIER
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org