[FFmpeg-devel] [PATCH] Add AVFilter.next field

Vitor Sessak vitor1001
Sun Oct 25 01:34:36 CEST 2009

Stefano Sabatini wrote:
> On date Saturday 2009-10-24 23:23:31 +0200, Michael Niedermayer encoded:
>> On Sat, Oct 24, 2009 at 01:40:29AM +0200, Stefano Sabatini wrote:
>>> Hi all,
>>> this simplify the code and should also simplify the av_filter_next()
>>> function which I'm going to implement, making it O(1) rather than
>>> O(N), and making the registration management similar to that
>>> implemented in the rest of libav*.
>>> I don't know why the registration mechanism has been implemented like
>>> this in lavfi, so I may be un-aware of some specific reason.
>> The idea was that AVFilter should be possible to be put into read only
>> and shareable memory. A next that is written to breaks this.
>> note, i dont have a strong oppinion on this being worth the extra complexity
> Neither do I, so I think that I'll leave to you or to Vitor the
> choice, if there is some test I could do to help the choice let me
> know.

While I think it is sad we cannot make the AVFilter structs const, the 
static allocation (and corresponding free'ing) is worse, so I prefer the 
code after your patch. BTW, any reason not to remove avfilter_uninit() 
(in the same way we do not have an avcodec_uninit())?


More information about the ffmpeg-devel mailing list