[FFmpeg-devel] [PATCH] Another function shared between AMR and SIPR

Michael Niedermayer michaelni
Tue Oct 27 11:33:44 CET 2009


On Mon, Oct 26, 2009 at 12:12:46AM +0100, Vitor Sessak wrote:
> $subj
[...]
> Index: libavcodec/acelp_pitch_delay.h
> ===================================================================
> --- libavcodec/acelp_pitch_delay.h	(revision 20368)
> +++ libavcodec/acelp_pitch_delay.h	(working copy)
> @@ -220,4 +220,18 @@
>      int subframe_size,
>      int max_pred_order);
>  
> +/**
> + * Calculate fixed gain (part of section 6.1.3 of AMR spec)
> + *
> + * @param fixed_gain_factor gain correction factor
> + * @param fixed_energy decoded algebraic codebook vector energy
> + * @param prediction_error vector of the quantified predictor errors of previous
> + *        subframes
> + * @param energy_mean desired mean innovation energy
> + * @param pred_table moving average coefficients


> + */
> +float ff_set_fixed_gain(float fixed_gain_factor, float fixed_mean_energy,

"amr" should be in the name or something else that makes it clear what
this global function does

also nothing in this text hints on how many entries the arrays should have
its surely written in the amr spec but i think its better if its also
documented here

and then prediction_error is updated by this function and nothing hints
at that in the doxy

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I wish the Xiph folks would stop pretending they've got something they
do not.  Somehow I fear this will remain a wish. -- M?ns Rullg?rd
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091027/e318e145/attachment.pgp>



More information about the ffmpeg-devel mailing list