[FFmpeg-devel] Indeo3 replacement, take 3

Vitor Sessak vitor1001
Fri Oct 30 01:18:19 CET 2009


Maxim wrote:
> Hello crews,
> 
> attached a new version of my indeo3 decoder replacing the existing one
> from the FFmpeg's svn.

Some random minor comments:

> /**
>  *  Some constants for parsing frame flags.
>  */
> #define BS_8BIT_PEL     1<<1
> #define BS_KEYFRAME     1<<2
> #define BS_MV_Y_HALF    1<<4
> #define BS_MV_X_HALF    1<<5
> #define BS_NONREF       1<<8

I suggest

#define BS_8BIT_PEL     (1<<1)

Also it would be nice if the comment allows one to readily understand 
what BS stands for here (bitstream?).

> typedef struct {
>     const int8_t    *delta_tab;
>     uint16_t        num_dyads;
>     int16_t         quad_exp;
> } vqtEntry;

These fit in uint8_t and int8_t.

-Vitor



More information about the ffmpeg-devel mailing list