[FFmpeg-devel] [PATCH] mov reference files search improvement

Diego Biurrun diego
Wed Sep 2 14:55:14 CEST 2009


On Wed, Sep 02, 2009 at 03:54:01PM +0300, Maksym Veremeyenko wrote:
> Diego Biurrun ???????(??):
> >On Wed, Sep 02, 2009 at 02:56:38PM +0300, Maksym Veremeyenko wrote:
> >>Diego Biurrun ???????(??):
> >>>On Wed, Sep 02, 2009 at 01:26:11PM +0300, Maksym Veremeyenko wrote:
> >>>>Diego Biurrun ???????(??):
> >>>>>On Wed, Sep 02, 2009 at 09:55:32AM +0300, Maksym Veremeyenko wrote:
> [...]
> >>newer patch attached.
> >>
> >>--- libavformat/mov.c	(revision 19698)
> >>+++ libavformat/mov.c	(working copy)
> >>@@ -273,41 +273,72 @@
> >>+                } else if (type == 0) { // directory name
> >
> >if (!type)
> I vote to leave it unchanged, because the *type* is compared against 
> constant - it not just "zero".

Keep it then.

Diego



More information about the ffmpeg-devel mailing list