[FFmpeg-devel] [PATCH] mov reference files search improvement

[Maksym Veremeyenko]

Diego Biurrun ???????(??):
> On Wed, Sep 02, 2009 at 03:54:01PM +0300, Maksym Veremeyenko wrote:
>> Diego Biurrun ???????(??):
>>> On Wed, Sep 02, 2009 at 02:56:38PM +0300, Maksym Veremeyenko wrote:
>>>> Diego Biurrun ???????(??):
>>>>> On Wed, Sep 02, 2009 at 01:26:11PM +0300, Maksym Veremeyenko wrote:
>>>>>> Diego Biurrun ???????(??):
>>>>>>> On Wed, Sep 02, 2009 at 09:55:32AM +0300, Maksym Veremeyenko wrote:
[..]
 >> --- libavformat/mov.c	(revision 19698)
 >> +++ libavformat/mov.c	(working copy)
 >> @@ -273,41 +273,72 @@
 >>
 >> -                av_log(c->fc, AV_LOG_DEBUG, "type %d, len %d\n", 
type, len);
 >> +                av_log(c->fc, AV_LOG_DEBUG, "type %d, len %d\n",
 >> +                       type, len);
 >
 > cosmetics
rolled back

>>>> --- libavformat/mov.c	(revision 19698)
>>>> +++ libavformat/mov.c	(working copy)
>>>> @@ -273,41 +273,72 @@
>>>> +                } else if (type == 0) { // directory name
>>> if (!type)
>> I vote to leave it unchanged, because the *type* is compared against 
>> constant - it not just "zero".
> 
> Keep it then.
thanks

newer version attached

-- 
________________________________________
Maksym Veremeyenko
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mov_refs_search_v5.patch
Type: text/x-patch
Size: 9319 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090902/1d365ca5/attachment.bin>