[FFmpeg-devel] [PATCH] increase MAX_AUDIO_FRAMESIZE

Michael Niedermayer michaelni
Thu Sep 3 14:58:42 CEST 2009


On Wed, Sep 02, 2009 at 10:14:37PM +0200, Sascha Sommer wrote:
> Hi,
> 
> On Mittwoch, 2. September 2009, Michael Niedermayer wrote:
> > On Wed, Sep 02, 2009 at 09:16:26PM +0200, Sascha Sommer wrote:
> > > Hi,
> > >
> > > On Mittwoch, 2. September 2009, Michael Niedermayer wrote:
> > > > On Wed, Sep 02, 2009 at 08:03:02PM +0300, Kostya wrote:
> > > > > On Wed, Sep 02, 2009 at 07:00:32PM +0200, Sascha Sommer wrote:
> > > > > > Hi,
> > > > > >
> > > > > > attached patch increases the maximum audio framesizes. This makes
> > > > > > it possible to play a few more wmapro files.
> > > > >
> > > > > And WavPack too :)
> > > > >
> > > > > > Regards
> > > > > >
> > > > > > Sascha
> > > > >
> > > > > I wonder how long we will increase that buffer before someone
> > > > > proposes better buffer allocation system.
> > > >
> > > > i wonder if the decoders could maybe output smaller chunks?
> > > > its better memory wise, better cache wise and also improves
> > > > AV sync buffering requirements
> > >
> > > I wonder if it would help if the decode function could output smaller
> > > chunks and set some flag so that it gets called again with the same
> > > AVPacket?
> >
> > doesnt it already?
> >
> 
> I don't know. Is there some documentation available somewhere? I tryed it 
> before the AVPacket param was added and back then it did not return the rest 
> of the buffer when you returned a value smaller than the passed in input 
> buffer size.

hmm
it definitly should return the rest see:
                ret = avcodec_decode_audio3(ist->st->codec, samples, &data_size,
                                            &avpkt);
                if (ret < 0)
                    goto fail_decode;
                avpkt.data += ret;
                avpkt.size -= ret;



[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090903/78e3acde/attachment.pgp>



More information about the ffmpeg-devel mailing list