[FFmpeg-devel] [PATCH]Do not allow 0 threads

Michael Niedermayer michaelni
Thu Sep 3 15:06:18 CEST 2009


On Wed, Sep 02, 2009 at 04:57:02PM -0700, Jason Garrett-Glaser wrote:
> On Wed, Sep 2, 2009 at 4:37 PM, Baptiste
> Coudurier<baptiste.coudurier at gmail.com> wrote:
> > Hi Carl Eugen,
> >
> > On 09/02/2009 04:12 PM, Carl Eugen Hoyos wrote:
> >>
> >> Hi!
> >>
> >> Attached patch should fix issue 1333.
> >>
> >
> > Isn't 0 threads, "auto" with libx264 ?
> 
> Yes, though only because 0 happens to be defined as X264_THREADS_AUTO
> in x264.h.  Proper fix would be to actually parse "auto" on the
> commandline correctly, but if that can't be done, it's at least better

parsing auto on the command line requires adding 1 lines of code to the
AVOption table

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090903/a25c72c4/attachment.pgp>



More information about the ffmpeg-devel mailing list