[FFmpeg-devel] [PATCH] non-interleaved AVI read packet fix

[Michael Niedermayer]

On Thu, Sep 03, 2009 at 06:45:51PM +0300, Maksym Veremeyenko wrote:
> Michael Niedermayer ???????(??):
>> On Thu, Sep 03, 2009 at 04:58:07PM +0300, Maksym Veremeyenko wrote:
>>> Michael Niedermayer ???????(??):
>>>> On Thu, Sep 03, 2009 at 08:27:07AM +0300, Maksym Veremeyenko wrote:
>>>>> Michael Niedermayer ???????(??):
>>>>>> On Wed, Sep 02, 2009 at 09:22:42AM +0300, Maksym Veremeyenko wrote:
> [...]
>> the  st->nb_index_entries check has to be factored out first or this can
>> crash i think
>
> Some code bellow already has a:
>
> [...]
>             if(ts < best_ts && st->nb_index_entries){
>                 best_ts= ts;
>                 best_st= st;
>                 best_stream_index= i;
>             }
> [...]
>
> so may be it has a sense to simplify this condition too (like in attached 
> patch) if checking for st->nb_index_entries will be first?

the patch is ok if tested but it should be split
its really a factorization and a bugfix and could be hard to understand
in a year by someone not familiar with the code if its commited combined

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090903/72f5ed2b/attachment.pgp>