[FFmpeg-devel] eliminate sws_format_name - is this any good?

[Michael Niedermayer]

On Sat, Sep 05, 2009 at 12:27:52AM +0200, Lars T?uber wrote:
> I thought it might be a very small simplification.

> But it adds a dependency to avcodec.

i dont think this is a good tradeoff ...


[...]
> Index: libswscale/swscale.c
> ===================================================================
> --- libswscale/swscale.c	(revision 29647)
> +++ libswscale/swscale.c	(working copy)
> @@ -364,118 +364,6 @@
>  };
>  #endif
>  
> -const char *sws_format_name(enum PixelFormat format)
> -{
> -    switch (format) {
> -    case PIX_FMT_YUV420P:
> -        return "yuv420p";
> -    case PIX_FMT_YUVA420P:
> -        return "yuva420p";
> -    case PIX_FMT_YUYV422:
> -        return "yuyv422";

this code should be formated like

> -    case PIX_FMT_YUV420P:    return "yuv420p";
> -    case PIX_FMT_YUVA420P:   return "yuva420p";
> -    case PIX_FMT_YUYV422:    return "yuyv422";

its more readable ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090910/74de2077/attachment.pgp>