[FFmpeg-devel] [PATCH] probetest.c

Michael Niedermayer michaelni
Tue Sep 15 10:46:04 CEST 2009


On Tue, Sep 15, 2009 at 09:23:13AM +0200, Reimar D?ffinger wrote:
> On Tue, Sep 15, 2009 at 12:34:04AM +0200, Michael Niedermayer wrote:
> > On Mon, Sep 14, 2009 at 05:19:03PM +0200, Michael Niedermayer wrote:
> > > Some simple probe testing code should be attached
> > > 
> > > its output, aka formats that detect random data with a score >25 are:
> > > Failure of h261 probing code with score=50 type=0 p=B53 size=2
> > > Failure of vc1test probing code with score=50 type=0 p=40E size=4
> > > Failure of h263 probing code with score=50 type=0 p=C1E size=4
> > > Failure of idcin probing code with score=50 type=0 p=E93 size=8
> > > Failure of mm probing code with score=50 type=0 p=FC0 size=128
> > > Failure of dv probing code with score=75 type=1 p=E85 size=256
> > > Failure of vmd probing code with score=50 type=0 p=AF4 size=512
> > > Failure of mpeg probing code with score=52 type=0 p=D9C size=4096
> > > Failure of dts probing code with score=51 type=1 p=B8F size=8192
> > > 
> > > maintainers of the listed formats should look into fixing their probe
> > > code!
> > > ill try to look at h26*/mpeg if i find the time, that said if someone
> > > else is faster thats welcome of course ...
> > 
> > and as everyone celebrates victory, probetest returns from the depths of
> > hell stronger and more evil to devour more demuxers
> 
> I think with enough effort you can make any demuxer fail, unless they
> have a huge an truly random signature.

with the curent probe functions, maybe, but i really dont think one would
be able to actually generate valid files of many formats like that.


> Maybe should add some options to limit its agressiveness, because unless
> it is a test that most/all other demuxers pass I don't think it is a
> convincing argument to make everyone fix their code (though ignore that
> if the list is only so large because the patches I sent are not included
> in the FFmpeg you tested).

ill commit probetest later today, then people can add all the options they
want to water it down, or do you want me to add some before commit?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090915/dc1a0895/attachment.pgp>



More information about the ffmpeg-devel mailing list