[FFmpeg-devel] [PATCH] MPEG-2 encoding of large frames

Martin Fiedler martin.fiedler
Thu Sep 17 07:00:39 CEST 2009


On Wed, 16 Sep 2009 20:39:09 +0200
Michael Niedermayer <michaelni at gmx.at> wrote:

> >  void ff_mpeg1_encode_slice_header(MpegEncContext *s){
> > +    if ((s->codec_id == CODEC_ID_MPEG2VIDEO) && (s->height > 2800)) {
> 
> superflous ()

OK. I removed the codec ID check completely, because after having re-read
the spec, nothing suggests that slice_vertical_position_extension is
specific to MPEG-2.

> > -    put_header(s, SLICE_MIN_START_CODE + s->mb_y);
> > +        put_header(s, SLICE_MIN_START_CODE + s->mb_y);
> 
> should be a seperate patch maybe

I don't get that. It's not just a cosmetic change: the line has been
indented because it's now in the else{} clause.

I attached a slightly updated patch.

Best regards,

Martin J. Fiedler
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mpeg2enc-large-frames.rev2.patch
Type: text/x-diff
Size: 654 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090917/f7132257/attachment.patch>



More information about the ffmpeg-devel mailing list