[FFmpeg-devel] [PATCH] align pix_fmt list

Michael Niedermayer michaelni
Sun Sep 20 23:31:54 CEST 2009


On Sun, Sep 20, 2009 at 01:00:26PM -0400, Justin Ruggles wrote:
> Justin Ruggles wrote:
> 
> > Ramiro Polla wrote:
> > 
> >> On Sun, Sep 20, 2009 at 11:52 AM, Justin Ruggles
> >> <justin.ruggles at gmail.com> wrote:
> >>> There are some pixel format names with more than 10 characters, so they
> >>> mess up the list alignment.  Patch attached.
> >> [...]
> >>
> >>> diff --git a/libavcodec/imgconvert.c b/libavcodec/imgconvert.c
> >>> index ecadd63..8e0490a 100644
> >>> --- a/libavcodec/imgconvert.c
> >>> +++ b/libavcodec/imgconvert.c
> >>> @@ -585,7 +585,7 @@ void avcodec_pix_fmt_string (char *buf, int buf_size, enum PixelFormat pix_fmt)
> >>>          char is_alpha_char= info.is_alpha ? 'y' : 'n';
> >>>
> >>>          snprintf (buf, buf_size,
> >>> -                  "%-10s" "      %1d     " "   %2d " "     %c   ",
> >>> +                  "%-11s" "     %1d     " "   %2d " "     %c   ",
> >>>                    info.name,
> >>>                    info.nb_channels,
> >>>                    info.depth,
> >> That's a weird format string. Why isn't it simply "%-16s%-8s%-6s%c" ?
> >> It gets filled up with whitespace anyways.
> > 
> > It is weird... Your suggestion is not quite the same, but here is a new
> > patch that is equivalent except for the trailing spaces.
> 
> or this patch, which allows for the pixel format name to grow some more.

i do not want it to grow further!
the +1 size is of course ok though

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090920/d51e60b7/attachment.pgp>



More information about the ffmpeg-devel mailing list