[FFmpeg-devel] [PATCH] id3v2: read TXXX frames

[Daniel Verkamp]

On Mon, Sep 28, 2009 at 8:47 AM, Anton Khirnov <wyskas at gmail.com> wrote:
> i hope this looks better.
>
> also added a check for "TXX" frames used in id3v2.2 tags.
>
> and i should probably mention that this patch depends on id3v2
> metadata conversion table from "mp3 muxer: write all metadata" thread
> :)
>
> On Mon, Sep 28, 2009 at 11:38 AM, Daniel Verkamp <daniel at drv.nu> wrote:
>>
>> Surely the FFMIN is not necessary at all here due to dst[dstlen] = 0
>> just previously... if the string is shorter than dstlen - 1, then the
>> strlen() result will be used, and the only other possible case is
>> strlen(dst) == dstlen - 1, so just
>>
>> ?val = dst + strlen(dst) + 1
>>
>> should be enough.
>
> unless i'm missing something, there's exactly dstlen bytes between
> dst[0] and dst[dstlen], so strlen(dst) == dstlen in the worst case.
>
> Anton Khirnov
>

You are right, of course - answering mail at 4 AM not recommended. :)

-- Daniel Verkamp