[FFmpeg-devel] [PATCH 06/12] WMA: use float_to_int16_interleave

Reimar Döffinger Reimar.Doeffinger
Tue Sep 29 16:16:47 CEST 2009


On Sun, Sep 27, 2009 at 11:49:22AM +0100, Mans Rullgard wrote:
> +    if (s->dsp.float_to_int16_interleave == ff_float_to_int16_interleave_c)
> +        for (ch = 0; ch < s->nb_channels; ch++)
> +            for (i = 0, iptr = s->frame_out[ch]; i < s->frame_len; i++, iptr++)
> +                *iptr = *iptr / 32768.0f + 385.0f;
> +    s->dsp.float_to_int16_interleave(samples, s->frame_out_ptr, s->frame_len,
> +                                     s->nb_channels);

This kind of code is a really mean thing and this would be the third
place where it is added.
Curiously aac and dca do not use that comparison, and the documentation
for float_to_int16_interleave provides no explanation.
Thus I'd like to request a cleanup/fixed documentation first, please :-)



More information about the ffmpeg-devel mailing list