[FFmpeg-devel] [PATCH] Redefine AVERROR_EOF as a specific FFmpeg error code at the next lavu major bump

[Stefano Sabatini]

On date Saturday 2010-04-03 22:03:23 +0200, Michael Niedermayer encoded:
> On Sat, Apr 03, 2010 at 05:08:48PM +0200, Stefano Sabatini wrote:
[...]
> > Regression test passed (both with LIBAVUTIL_MAJOR_VERSION == 50 and ==
> > 51).
> 
> bumping it to 51 will changes the codes returned by all libs using libavutil
> all of them would need to bump major.
> i dont think this is reasonable, thus we should undo all error redefinitions
> before they become real and debian burns you at the stake

/* the jackasses changed the error codes, so I need to build a
 * backward compatibility layer */
#if LIBFOO_VERSION < NEXT && LIBAVUTIL_VERSION_MAJOR > 50
#define FOO_GET_AV_ERROR_CODE(err) (err == AVERROR_EOF         ? AVERROR(EPIPE ) : \
                                    err == AVERROR_NUMEXPECTED ? AVERROR(EDOM)   : \
                                    err == AVERROR_INVALIDDATA ? AVERROR(EINVAL) : err)
#else
#define FOO_GET_AV_ERROR_CODE(err) (err)
#endif


I'm not saying that's nice, but at least it is possible. Also keeping
garbage forever for the fear to break applications is not good.

Regards.
-- 
FFmpeg = Fierce & Forgiving Mean Philosofic Encoding/decoding God