[FFmpeg-devel] [PATCH] RTMP seek support

Howard Chu hyc
Wed Apr 7 07:50:21 CEST 2010


Michael Niedermayer wrote:
> On Thu, Apr 01, 2010 at 01:11:24PM -0700, Howard Chu wrote:
>> Michael Niedermayer wrote:
>>> On Wed, Mar 31, 2010 at 05:24:49PM -0700, Howard Chu wrote:
>>>> Howard Chu wrote:
>>>>> Michael Niedermayer wrote:
>>>>>> removial is planed but the new API might be changed if we find the need
>>>>>> to change it still ...
>>>>
>>>> It seems to me that one thing that ought to be changed is that rescaling
>>>> the timestamp should still be done by the caller, not in read_seek2.
>>>> Right
>>>> now each implementation of read_seek2() has to duplicate this code.
>>>
>>> if rescaling is done outside then exact seeking becomes impossible
>>> because rescaling implicates rounding
>>
>> But that's always true, regardless. If you sepcify a seek timestamp in
>> nanoseconds and the stream only supports microseconds, it is going to have
>> to round anyway.
>
> there are normally several streams, and their timebases normally differ.

That cannot be true in an FLV.

Anyway, I give up. I have no idea what you expect a real read_seek2() 
implementation to do in this context. If these patches are wrong, whatever. 
The functionality is broken right now and I'm tired of trying to guess what 
other problem is going to crop up.

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: dif.txt
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100406/7dd675dc/attachment.txt>



More information about the ffmpeg-devel mailing list