[FFmpeg-devel] [PATCH] Fix memory leaks in the AAC RTP depacketization code

Luca Barbato lu_zero
Fri Apr 9 11:40:12 CEST 2010


On 04/05/2010 07:05 PM, Martin Storsj? wrote:
> On Mon, 5 Apr 2010, Ronald S. Bultje wrote:
> 
>> On Apr 5, 2010, at 4:22 AM, Martin Storsj? <martin at martin.st> wrote:
>>> The code currently allocates a new buffer for AUHeaders for each  
>>> packet it
>>> receives, without freeing the previous one - this fixes the issue.  
>>> It also
>>> frees an av_strduped string of a few bytes.
>>
>> Why is this not a rtpdynamicpayloadhandler?
> 
> Just since it originated writtein in that way, I think. The code is quite 
> ugly imo, with hardcoded support for one particular format in the general 
> rtpdec and rtsp code. Cleaning this up properly perhaps is a suitable task 
> for Josh?

I think so.

lu

-- 

Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero




More information about the ffmpeg-devel mailing list